SIMD-0499: Deactivate execution of loader-v1 and ABI-v0#499
SIMD-0499: Deactivate execution of loader-v1 and ABI-v0#499Lichtso wants to merge 3 commits intosolana-foundation:mainfrom
Conversation
|
Hello Lichtso! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here. This PR requires the following approvals before it can be merged:
Once all requirements are met, you can merge this PR by commenting |
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Can you link the discussion thread? #483
Personally I think this SIMD is a bit premature. I think we should have had more discussion in #483 first, and reached a conclusion on what to do about programs like Memo and Serum. We should still do that over in the discussion and add updates here to the proposal accordingly!
| ## Impact | ||
|
|
||
| The only loader-v1 / ABIv0 program still in use today is Memo Program v1. | ||
| Of which there has been a loader-v2 / ABIv1 replacement around for a long time. |
There was a problem hiding this comment.
I would use my research tooling to flesh out this section and be as detailed as possible about who's going to break, what their transaction traffic looks like, and why we deem it's acceptable to break them. We should present a solid case for completely deactivating an ABI version, even if it's old.
There was a problem hiding this comment.
It's also worth making it explicitly clear that on-chain programs under Loader v1 will be bricked forever.
There was a problem hiding this comment.
Reiterating that the tooling is available to add qualitative metrics to the Impact section.
There was a problem hiding this comment.
I added you to the authors and "Allow edits and access to secrets by maintainers" is enabled. You should be able to commit and push your analysis yourself.
There was a problem hiding this comment.
That's okay I'd rather still be able to review/approve.
I suggest placing the truncated statistics from my comment here in the Impact section and then also including a supporting doc with the full sparkline plot from running the program-sync tool:
cargo run --release -- rpc program-ids --loader 1
cargo run --release -- rpc usage --file <OUT_FILE>
It's imperative that we publish all of the data about Loader V1 programs before anyone can collectively agree to disable them forever.
Is already linked in the "Motivation" section, unless you want me to move it to the PR description instead. |
|
Thanks, topointon-jump! |
Lichtso
force-pushed
the
deactivate-execution-of-loader-v1-and-abi-v0
branch
from
cf18e31 to
4740305
Compare
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
This is looking pretty good, but I'm adamant about including the data on Loader V1 traffic in this proposal. It should not be taken lightly.
Once we have all of the data included, it's probably best to mark this as a draft and iron out the what-if's in the discussion thread first. What do you think?
3 participants
See the related SIMD discussion.